Uniformly disable assertions on release builds and enable them for tests - #278
Merged
Merged
Conversation
Contributor
|
Makes sense, and the test is passing. Thanks @ngoldbaum |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently the Linux and iOS wheels are built with debug assertions enabled. This could lead to aborts at runtime for release builds if someone happens to hit an assert. The Mac and Windows wheels do not have asserts.
I'm pretty sure this was unintentional: setuptools 75.7.0 and newer no longer inherit
-DNDEBUGfrom CPython.This PR sets up an intentional policy: release wheels shouldn't have asserts but wheels built for testing and other test jobs should have asserts enabled. Also sets up CI scaffolding and a test for this.
I have a followup PR that uses asserts to document and enforce invariants which led me to notice and think about this.