Pre-check bans before applying filters that result in a ban#3536
Merged
Conversation
ChrisLovering
approved these changes
Jul 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to #3533 and #3534.
Instead of trying to cache actions we can probably achieve this simpler by just not applying the ban if a record already exists in site of this.
Alerts will still fire and will attempt to execute all actions as normal (which was the problem with previous PRs as all actions were suppressed for subsequent filters trips), this specifically suppresses the ban action from running again if a record already exists.
This will stop the message being left behind in channels that the user already had a ban infraction and will prevent the logs that are ending up in Sentry about users already having active infractions.