Repository navigation
Conversation
Convert values to string before applying prefix slicing so numeric and non-string values can be sliced with prefix modifiers without raising TypeError. In reserved expansion, split on existing percent-encoded triplets so unescaped characters are quoted without double-encoding existing percent escapes.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #163
Prefix modifiers caused a
TypeErrorwhen values were integers or floats becausevalue[:prefix]expected subscriptable objects. Converting the value to string first before slicing allows prefix modifiers to work on numeric values.In reserved expansions,
_only_quote_unquoted_charactersskipped quoting entirely if the string already contained any percent-encoded characters, leaving characters like spaces unencoded. Splitting on valid percent-encoded triplets allows preserving existing escapes while encoding remaining unescaped characters.