Repository navigation
[pre-commit.ci] pre-commit autoupdate - #59
pre-commit-ci[bot] wants to merge 1 commit into
Conversation
0d88737 to
7527a98
Compare
188b891 to
77a4a4d
Compare
3de6544 to
e54e546
Compare
e54e546 to
abdc6da
Compare
ea7b80c to
01c252c
Compare
3b32a49 to
55fcac4
Compare
yangfan-yf-yf
left a comment
There was a problem hiding this comment.
I reviewed the current config-only update. It advances the pinned revisions for pre-commit, ruff-pre-commit, and zizmor-pre-commit without changing hook IDs or local hook arguments.
The current GitHub matrix is green for Ubuntu, macOS, and Windows on Python 3.10 through 3.14. No additional project-source changes are included.
55fcac4 to
f2a9be2
Compare
f2a9be2 to
afc0ba0
Compare
yangfan-yf-yf
left a comment
There was a problem hiding this comment.
At afc0ba0, the pre-commit.ci check is failing because the Ruff pin crosses the 0.16 default-rule expansion.
I reproduced this against the exact tree:
- Ruff 0.15.10 passes with no fixes or cache.
- Ruff 0.16.1 reports only PLW1510 at src/poetry_plugin_shell/shell.py:93 and PLR1704 at tests/conftest.py:214.
This repository uses lint.extend-select, so Ruff 0.16's expanded defaults remain enabled. The smallest behavior-preserving fixes are:
- pass check=False to subprocess.run; the existing code already reads and returns returncode;
- rename the inner name loop variable, for example to dependency_name.
With those two edits, Ruff 0.16.1 passes and the full test suite reports 17 passed. I opened #61 to keep the source preparation separate. Please merge that source fix and refresh this branch before merging the config update.
afc0ba0 to
c50c6f6
Compare
2703be1 to
e7c2535
Compare
yangfan-yf-yf
left a comment
There was a problem hiding this comment.
I rechecked e7c2535. All 15 Ubuntu, macOS, and Windows test jobs pass, but the required pre-commit.ci - pr context still fails. Running Ruff 0.16.4 against this exact tree reproduces only the same two findings:
PLW1510atsrc/poetry_plugin_shell/shell.py:93;PLR1704attests/conftest.py:214.
Ruff formatting and git diff --check pass. This refreshed branch still does not contain the two behavior-preserving source changes in #61, so please merge #61 before refreshing the config update again.
7008f1e to
eb8e815
Compare
53062f5 to
e1eb656
Compare
e1eb656 to
3aefbbd
Compare
572927a to
bf86315
Compare
6e5b5c5 to
ee9b7ce
Compare
ee9b7ce to
1a9f7ea
Compare
updates: - [github.com/pre-commit/pre-commit: v4.5.1 → v4.7.0](pre-commit/pre-commit@v4.5.1...v4.7.0) - [github.com/astral-sh/ruff-pre-commit: v0.15.10 → v0.17.4](astral-sh/ruff-pre-commit@v0.15.10...v0.17.4) - [github.com/woodruffw/zizmor-pre-commit: v1.24.1 → v1.32.0](zizmorcore/zizmor-pre-commit@v1.24.1...v1.32.0)
1a9f7ea to
feeae6d
Compare
updates: