Document subprocess worker-thread context inheritance - #3505
Closed
roli-lpci wants to merge 1 commit into
Closed
Conversation
Contributor
|
I'm not willing to waste my time reviewing this given how many open PRs you have + LLM generated PR description. I also think it's not exactly right because I don't think docs really address the issue, or at least I'm not yet convinced there isn't a solution. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
trio.run_processandtrio.lowlevel.open_processcallsubprocess.Popenfrom a worker threadinherited from the worker thread, with Linux namespaces and CPU affinity as
examples
This addresses the documentation request in #3360. It leaves the API and
spawning behavior unchanged; #3462's synchronous-spawn option was closed because
blocking the Trio event loop is unacceptable.
Validation
subprocess.Popen, launched a child,and confirmed that
Popenran on a different OS thread from Trio's event loopsphinx-build -W --keep-going -b html docs/source ...towncrier build --draftpre-commitchecks for the two changed files