Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fr_ssn("1 84 12 76 45 089")andfr_ssn("1 84 12 971 451 089")returnTrue: omitting the optional control key bypasses the existing check on department/town widths. The first value has too few birthplace digits and the second has too many.Run that structural check before the optional-control-key return. Add four invalid cases and three valid cases without control keys, covering mainland, Corsica, overseas and foreign birthplaces.
Validation: four new cases fail before the fix. The full default pytest run passes 1,523 tests;
tox -e lint,type,format,sast,py313also passes (1,581 tests and doctests). Baseline default pytest: 1,516 passing tests.Found and implemented with Codex during a code audit; the reproduction and checks were run locally.