Repository navigation
docs: clarify WMS background transparency and test output options - #2306
Open
senanurcetin wants to merge 1 commit into
Open
senanurcetin wants to merge 1 commit into
senanurcetin wants to merge 1 commit into
Conversation
Author
|
Hi Folium maintainers, This PR clarifies the behavior of WMS background transparency and adds assertions for the generated WMS layer options. The changes are intentionally limited to documentation and tests. The GitHub Actions workflows currently show AI assistance was used in preparing this contribution. Thank you for your time! |
senanurcetin
added a commit
to senanurcetin/folium
that referenced
this pull request
Oct 20, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR clarifies the behavior of
transparent=Truein Folium'sWmsTileLayerdocumentation and strengthens the existing regression test.Related to #1808.
Problem
The
transparent=Trueoption is correctly passed to Leaflet, but it does not make existing black or opaque pixels in WMS imagery transparent.Transparency depends on the WMS server, the requested layer, and the image format.
Changes
image/png."transparent": true"format": "image/png"Scope: 2 files modified, 8 lines added. No API or rendering behavior changes.
Testing
git diff --checkpassed.Local tests used Folium 0.20.0 and an upstream-derived partial test checkout. Full upstream pytest, Ruff, Black, Sphinx, and Selenium checks were not executed locally and remain subject to CI verification.
AI Assistance Disclosure
AI assistance was used to investigate the issue, review existing implementation and documentation, prepare the changes, and perform focused local validation.
The contribution remains subject to maintainer review and project CI checks.