docs(proposals): add SHA-256 digest capture and verification proposal - #1310
docs(proposals): add SHA-256 digest capture and verification proposal#1310LalatenduMohanty wants to merge 1 commit into
Conversation
|
Warning Review limit reachedNext included review available in 4 minutes. View limit detailsLimit details: You’ve used the included review currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Team Run ID: 📒 Files selected for processing (1)
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Team Run ID: 📒 Files selected for processing (1)
Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review. 📝 WalkthroughWalkthroughAdds a proposal for three phases of source provenance in Fromager. The design covers upstream identity, source transformations, build context, artifact digests, and storage in Estimated code review effort: 1 (Trivial) | ~5 minutes Merge Risk: 🔵 Low · up to This documentation-only proposal does not change runtime behavior, but its planned provenance records lack defined atomic update and recovery semantics, which could allow inconsistent verification or reuse state when implemented. The design is mergeable with explicit owner follow-up, and issue 🚥 Pre-merge checks | ✅ 2 | ❌ 2❌ Failed checks (2 warnings)
✅ Passed checks (2 passed)
Full details: Linked Issues checkExplanation The document addresses the linked issue conceptually, but it does not implement the requested Phase 1 changes. It adds no download hashing, digest verification, data-model fields, provenance output, or re-download checks. [ Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
4e4944a to
6f48046
Compare
Define SHA-256 capture and verification for downloaded artifacts to close fromager’s unverified-bytes supply-chain gap. Closes: python-wheel-build#1296 Co-Authored-By: Claude <claude@anthropic.com> Signed-off-by: Lalatendu Mohanty <lmohanty@redhat.com>
6f48046 to
f842140
Compare
Proposes computing, storing, and verifying SHA-256 digests for all downloaded artifacts to close the supply-chain gap where fromager accepts unverified bytes.
Closes: #1296