chore: merge constraints.txt and setup.cfg into pyproject.toml to simplify setup - #798
Open
ThosRTanner wants to merge 1 commit into
Open
chore: merge constraints.txt and setup.cfg into pyproject.toml to simplify setup#798ThosRTanner wants to merge 1 commit into
ThosRTanner wants to merge 1 commit into
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #798 +/- ##
==========================================
- Coverage 96.65% 95.41% -1.24%
==========================================
Files 27 27
Lines 3554 3858 +304
==========================================
+ Hits 3435 3681 +246
- Misses 119 177 +58 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
ThosRTanner
force-pushed
the
issue/786/rationalise_pins
branch
2 times, most recently
from
September 4, 2026 19:41
3a4595f to
d542b29
Compare
ThosRTanner
marked this pull request as ready for review
September 4, 2026 19:57
ThosRTanner
force-pushed
the
issue/786/rationalise_pins
branch
3 times, most recently
from
September 5, 2026 17:25
15c17d4 to
21f0b93
Compare
Consolidates setup.cfg and constraints.txt into pyproject.toml, and additionally cleans up the list so that only the optional eventlet, gevent and sasl dependencies are visible, the various dev ones are not. Updated pytest to the latest supporting 3.8 or it can't cope with the .toml file... Removed Makefile which isn't used anywhere and references a bunch of requirements*.txt files which don't exist.
ThosRTanner
force-pushed
the
issue/786/rationalise_pins
branch
from
September 5, 2026 17:27
21f0b93 to
c24cafe
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #786
Why is this needed?
Currently constraints are specified in 3 places which makes it hard to track what you need to change. I'm not an out and out lover of
pyproject.tomlbut having all module setup in one place makes it easier to control package version dependencies.All that is left in setup.cfg is the
tag_build = devto tag dev builds as such, as I've been unable to find an obvious equivalent inpyproject.tomlProposed Changes
constraints.txtandsetup.cfginfo intopyproject.toml. This also requires us to:tox.inito use new dependency groupsMakefilewhich has not been maintained and refers to non existent requirements filedocs/requirements.txttox -e docsactually generate the docs.Does this PR introduce any breaking change?
The internal dependencies are no longer leaked from
setup.cfg, and the top levelMakefilehas been removed. This shouldn't affect anyone, but one never knows...Codecov report
This appears to be because it's two commits out of date. This change hasn't affected what code is covered during tests