chore(typing): clean up some of the workrounds from the initial PR - #801
Draft
ThosRTanner wants to merge 1 commit into
Draft
chore(typing): clean up some of the workrounds from the initial PR#801ThosRTanner wants to merge 1 commit into
ThosRTanner wants to merge 1 commit into
Conversation
houndci-bot
reviewed
Sep 5, 2026
ThosRTanner
force-pushed
the
typing_cleanups_1
branch
3 times, most recently
from
September 5, 2026 17:38
9e173cb to
0090452
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #801 +/- ##
==========================================
- Coverage 96.65% 95.45% -1.20%
==========================================
Files 27 27
Lines 3554 3832 +278
==========================================
+ Hits 3435 3658 +223
- Misses 119 174 +55 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
ThosRTanner
force-pushed
the
typing_cleanups_1
branch
2 times, most recently
from
September 6, 2026 07:35
55a0f78 to
fa8a966
Compare
ThosRTanner
force-pushed
the
typing_cleanups_1
branch
from
September 6, 2026 07:36
fa8a966 to
d4b8623
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why is this needed?
This addresses some of the issues spotted when adding type checking but left until later due to the extent of the initial pull request.
Proposed Changes
self.assertRaiseshandles the parameter list.Does this PR introduce any breaking change?
If anyone directly calls
kazoo.hosts.collect_hostsit will no longer returnNonefor the chroot. It will return""in that situation. But that isn't part of the published API.