Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,12 @@ override its benchmark job timeout.

### Bugfixes

#### Build against OpenSSL 3 on macOS

macOS builds now default to Homebrew's `openssl@3` instead of the removed `openssl@1.1`.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we can be more specific and tell existing runner owners to run brew install openssl@3? Some setups, including mine, install bench_runner from a branch on each run, so they can pick up changes automatically. The provisioning instructions cover new setups, but existing runners may need that extra step.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do you think about 9c6b42e? To be honest, I think the best model here would be to use Ansible / Packer etc. We could also provide Brewfile? Not sure.

If `openssl@3` is not installed, run `brew install openssl@3` on existing macOS
runners before you update `bench_runner`.

#### Use PGO on weekly builds

Since 2.0.0, PGO was not being used on weekly builds. This is now fixed.
Expand Down
2 changes: 1 addition & 1 deletion PROVISIONING.md
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@ eval "$(/opt/homebrew/bin/brew shellenv)"
#### Install brew packages

```bash session
brew install openssl jq python@3.9 coreutils ccache
brew install openssl@3 jq python@3.9 coreutils ccache
```

## Microsoft Windows
Expand Down
2 changes: 1 addition & 1 deletion bench_runner/scripts/workflow.py
Original file line number Diff line number Diff line change
Expand Up @@ -143,7 +143,7 @@ def compile_unix(
env = os.environ.copy()

if util.get_simple_platform() == "macos":
openssl_prefix = util.get_brew_prefix("openssl@1.1")
openssl_prefix = util.get_brew_prefix("openssl@3")
env["PKG_CONFIG_PATH"] = f"{openssl_prefix}/lib/pkgconfig"

args = []
Expand Down
Loading