Skip to content

Incorrect error handling when compiler_set_qualname fails #156459

Closed
#156462
Closed
Incorrect error handling when compiler_set_qualname fails#156459
#156462
Labels
3.13only security fixes3.14bugs and security fixes3.15bugs and security fixes3.16new features, bugs and security fixestype-bugAn unexpected behavior, bug, or error

Description

@iritkatriel
iritkatriel
opened on Aug 27, 2026

compiler_set_qualname is called at the end of _PyCompile_EnterScope, after the compiler entered the scope. If it fails, _PyCompile_EnterScope returns error (without reverting the scope entry) and the caller would assume that there was no change in scope.

Linked PRs

Activity

  1. iritkatriel
    added
    3.13only security fixes
    3.14bugs and security fixes
    3.15bugs and security fixes
    3.16new features, bugs and security fixes
    type-bugAn unexpected behavior, bug, or error
    on Aug 27, 2026
  2. iritkatriel
    added 4 commits that reference this issue on Aug 27, 2026

    pythongh-156459: Fix cleanup on error in compiler_set_qualname

    eeec1f6

    Merge branch 'main' into pythongh-156459

    f8a86de

    Merge branch 'main' into pythongh-156459

    b17b75a

    Merge branch 'main' into pythongh-156459

    e67f535
  3. iritkatriel
    closed this as completedin #156462on Aug 29, 2026
  4. iritkatriel
    added a commit that references this issue on Aug 29, 2026

    gh-156459: Fix cleanup on error in compiler_set_qualname (#156462)

    8b082aa
  5. clin1234
    added a commit that references this issue on Sep 12, 2026

    pythongh-156459: Fix cleanup on error in compiler_set_qualname (pytho…

    8e636ff
  6. serhiy-storchaka
    added a commit that references this issue on Oct 10, 2026

    [3.15] gh-156459: Fix cleanup on error in compiler_set_qualname (GH-1…

    6295a17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    3.13only security fixes3.14bugs and security fixes3.15bugs and security fixes3.16new features, bugs and security fixestype-bugAn unexpected behavior, bug, or error

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions