-
-
Notifications
You must be signed in to change notification settings - Fork 35k
gh-153374: Better way to clear name error suggestion #141389
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Locked-chess-official
wants to merge
12
commits into
python:main
Choose a base branch
from
Locked-chess-official:clear_NameError_suggestion
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+24
−1
Open
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
5ac39e1
clear builtins in suggestion when deleting
Locked-chess-official d16cb29
add News
Locked-chess-official 50b0dbc
Merge branch 'main' into clear_NameError_suggestion
Locked-chess-official e2e8386
Update Lib/traceback.py
Locked-chess-official 47ab288
Remove repeat import of _colorize
Locked-chess-official 3006eef
add test
Locked-chess-official 45b3cd8
Merge branch 'main' into clear_NameError_suggestion
Locked-chess-official 0493ff2
Replace direct delete with exec in tests for rightly raise NameError
Locked-chess-official e8b47e4
Merge branch 'main' into clear_NameError_suggestion
Locked-chess-official 1a4c5e5
Merge branch 'main' into clear_NameError_suggestion
Locked-chess-official 6e895a8
Merge branch 'main' into clear_NameError_suggestion
Locked-chess-official b579cb7
Merge branch 'main' into clear_NameError_suggestion
Locked-chess-official File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 change: 1 addition & 0 deletions
1
Misc/NEWS.d/next/Core_and_Builtins/2025-11-11-14-21-33.gh-issue-138890.QwN0EU.rst
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| Use a more simple way to forbidden the builtins name suggestion in deleting |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure if these are necessary