gh-145857: Replace DELETE_GLOBAL with PUSH_NULL; STORE_GLOBAL#146314
Merged
Conversation
Changes: - Removed `DELETE_GLOBAL` opcode - Allowed `STORE_GLOBAL` to take a `NULL` value corresponding to deletion - Added test to `test_compiler_codegen.py`
brijkapadia
requested review from
ericsnowcurrently,
iritkatriel and
markshannon
as code owners
|
This PR is stale because it has been open for 30 days with no activity. |
Documentation build overview
31 files changed ·
|
brijkapadia
requested review from
AA-Turner,
StanFromIreland and
hugovk
as code owners
Member
|
Looks good. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes:
DELETE_GLOBALopcodeSTORE_GLOBALto take aNULLvalue corresponding to deletiontest_compiler_codegen.pyDELETE_GLOBALbytecode instruction #145857📚 Documentation preview 📚: https://cpython-previews--146314.org.readthedocs.build/