Skip to content

gh-148467: Move BufferedIOBase close to concrete implementations - #150838

Merged
cmaloney merged 2 commits into
python:mainfrom
serhiy-storchaka:docs-move-BufferedIOBase
Nov 12, 2026
Merged

cmaloney merged 2 commits into
python:mainfrom
serhiy-storchaka:docs-move-BufferedIOBase

Conversation

@serhiy-storchaka

@serhiy-storchaka serhiy-storchaka commented Jun 3, 2026 •

Copy link
Copy Markdown
Member

@serhiy-storchaka

Copy link
Copy Markdown
Member Author

@birkenfeld, @benjaminp, please take a look.

@read-the-docs-community

read-the-docs-community Bot commented Jun 3, 2026 •

Copy link
Copy Markdown

@StanFromIreland StanFromIreland left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. You have to fix the conflicts, however.

Comment thread Doc/library/io.rst Outdated
implies writing, so this mode behaves in a similar way to ``'w'``. Add a
``'+'`` to the mode to allow simultaneous reading and writing.

The :meth:`~RawIOBase.read` (when called with a positive argument),

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After this lands it looks like I missed this paragraph in gh-129011, these do have retries per PEP-475

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(They retry for EINTR, they don't retry for partial read or write)

@github-actions

Copy link
Copy Markdown

This PR is stale because it has been open for 90 days with no activity.

@github-actions github-actions Bot added the stale Stale PR or inactive for long period of time. label Oct 11, 2026
@cmaloney cmaloney removed needs backport to 3.13 only security fixes stale Stale PR or inactive for long period of time. labels Nov 12, 2026
@cmaloney
cmaloney merged commit ecefd40 into python:main Nov 12, 2026
35 checks passed
@miss-islington-app

Copy link
Copy Markdown

Thanks @serhiy-storchaka for the PR, and @cmaloney for merging it 🌮🎉.. I'm working now to backport this PR to: 3.14, 3.15.
🐍🍒⛏🤖

@github-project-automation github-project-automation Bot moved this from Todo to Done in Docs PRs Nov 12, 2026
@miss-islington-app

Copy link
Copy Markdown

Sorry, @serhiy-storchaka and @cmaloney, I could not cleanly backport this to 3.14 due to a conflict.

Please backport manually with cherry_picker, see the devguide for more information.

cherry_picker ecefd40671f340d543c214b80744d4301d249f37 3.14

@bedevere-app

bedevere-app Bot commented Nov 12, 2026

Copy link
Copy Markdown

GH-161917 is a backport of this pull request to the 3.15 branch.

@bedevere-app bedevere-app Bot removed the needs backport to 3.15 bugs and security fixes label Nov 12, 2026
cmaloney added a commit that referenced this pull request Nov 13, 2026
…ns (GH-150838) (#161917)

gh-148467: Move BufferedIOBase close to concrete implementations (GH-150838)

This reverts commit b6c7beb.
(cherry picked from commit ecefd40)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
Co-authored-by: Cody Maloney <cmaloney@theoreticalchaos.com>
@bedevere-app

bedevere-app Bot commented Nov 15, 2026

Copy link
Copy Markdown

GH-162038 is a backport of this pull request to the 3.14 branch.

@bedevere-app bedevere-app Bot removed the needs backport to 3.14 bugs and security fixes label Nov 15, 2026
hugovk added a commit that referenced this pull request Nov 15, 2026
…ns (GH-150838) (#162038)

This reverts commit b6c7beb.
(cherry picked from commit ecefd40)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
Co-authored-by: Cody Maloney <cmaloney@theoreticalchaos.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs Documentation in the Doc dir skip news

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants