GH-148874: Make sure that mngr.__exit__() is always called in a with statement#150911
Open
markshannon wants to merge 3 commits into
Open
GH-148874: Make sure that mngr.__exit__() is always called in a with statement#150911markshannon wants to merge 3 commits into
markshannon wants to merge 3 commits into
Conversation
…even if there is an interrupt during the call to mngr.__enter__()
markshannon
requested review from
Fidget-Spinner and
ericsnowcurrently
as code owners
markshannon
added
needs backport to 3.14
diegorusso
approved these changes
Jul 1, 2026
diegorusso
left a comment
diegorusso
left a comment
Contributor
There was a problem hiding this comment.
It looks good to me. This was already reviewed internally
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
... even if there is an interrupt during the call to
mngr.__enter__()When checking the eval breaker after a call, don't break if the previous code unit has
opcode == LOAD_SPECIAL.Sometimes a cache will appear to be a
LOAD_SPECIAL, but this is fine as this only applies to calls, and any loop will still have an eval breaker check on the back edge.with lock: can skip__exit__when a signal handler raises right after__enter__#148874