gh-152686: Quote '!' in venv activate.csh for (t)csh#152687
Open
tonghuaroot wants to merge 1 commit into
Open
Conversation
activate.csh substitutions were quoted with POSIX shlex.quote(), but (t)csh history-expands '!' even inside single quotes, so a venv created with e.g. --prompt 'py!env' could not be activated under csh/tcsh. Add quote_csh (escape '!') and dispatch on the .csh suffix, matching the existing quote_ps1/quote_bat handling from pythongh-124651, plus a regression test.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
activate.cshsubstitutions were quoted with POSIXshlex.quote(), but(t)csh history-expands
!even inside single quotes, so a venv created withe.g.
--prompt 'py!env'could not be activated under csh/tcsh.Add
quote_csh(escape!) and dispatch on the.cshsuffix, matching theexisting
quote_ps1/quote_bathandling from gh-124651, plus a regressiontest (
test_special_chars_csh_prompt).Verified under csh and tcsh:
!,',$, backtick,;,&&, spaces andparens round-trip; bash/fish activation is unchanged. A newline in a csh
single-quoted string is unrepresentable and remains out of scope.