gh-69134: Wait until mapped in SimpleDialog keyboard tests#152690
Open
serhiy-storchaka wants to merge 1 commit into
Open
gh-69134: Wait until mapped in SimpleDialog keyboard tests#152690serhiy-storchaka wants to merge 1 commit into
serhiy-storchaka wants to merge 1 commit into
Conversation
serhiy-storchaka
force-pushed
the
gh-69134-map-simpledialog-tests
branch
from
9fb01c8 to
99cf022
Compare
The SimpleDialog keyboard tests generate key events after focus_force(), which on Windows are dropped until the toplevel is mapped, so they could fail intermittently (seen on the Windows10 buildbot as test_return_no_default). Wait until the window is mapped in each of these tests, as pythonGH-152599 did for the other keyboard tests. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
serhiy-storchaka
force-pushed
the
gh-69134-map-simpledialog-tests
branch
from
99cf022 to
1b5a7b2
Compare
serhiy-storchaka
added
the
🔨 test-with-buildbots
|
🤖 New build scheduled with the buildbot fleet by @serhiy-storchaka for commit 1b5a7b2 🤖 Results will be shown at: https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F152690%2Fmerge If you want to schedule another build, you need to add the 🔨 test-with-buildbots label again. |
bedevere-bot
removed
the
🔨 test-with-buildbots
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
SimpleDialogtests generate key events afterfocus_force(). On Windows these are only delivered once the toplevel is mapped, so they could be dropped and the test fail intermittently — seen on the AMD64 Windows10 buildbot, wheretest_return_no_defaultfailed on the first run and passed on the re-run.Unlike the query dialogs (whose
__init__callswait_visibility()),SimpleDialogonly waits for its window ingo(), which these tests bypass. Wait until the window is mapped in thecreate()helper, as GH-152599 did for the other keyboard tests.