gh-152817: Prevent deletion of sqlite3 cursor.row_factory attr, missed from: gh-149738#152818
Open
stestagg wants to merge 3 commits into
Open
gh-152817: Prevent deletion of sqlite3 cursor.row_factory attr, missed from: gh-149738#152818stestagg wants to merge 3 commits into
cursor.row_factory attr, missed from: gh-149738#152818stestagg wants to merge 3 commits into
Conversation
prevent segfault and bring behaviour in line with docs
Contributor
Author
|
@sepehr-rs - You were the author of the original, are you able to take a look? Thanks in advance! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
gh-149738 prevents deletion of
row_factoryandtext_factoryattributes on a sqlite3 connection, this PR applies that fix tocursorobjects too, to avoid a similar segfault:I've piggy-backed off the existing docs change and blurb as that seems to cover this already
row_factoryattr of sqlite3cursor#152817