[WIP] Reference implementation: frozendict / frozenset literals and comprehensions#152820
Draft
sobolevn wants to merge 7 commits into
Draft
[WIP] Reference implementation: frozendict / frozenset literals and comprehensions#152820sobolevn wants to merge 7 commits into
frozendict / frozenset literals and comprehensions#152820sobolevn wants to merge 7 commits into
Conversation
sobolevn
requested review from
Eclips4,
JelleZijlstra,
carljm,
iritkatriel,
isidentical,
lysnikolaou,
markshannon,
pablogsal,
rhettinger and
tomasr8
as code owners
Documentation build overview
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
❄️❄️❄️ is here! ❄️❄️❄️
I splitted all my work into commits based on the area. So, it can be easier to review.
I also included quite a lot of tests.
TODO:
Things that I don't quite like yet:
_PySet_Updatechange to allowfrozensetupdatesPyFrozenDict_Newusage, that copies an existing dict to create a newfrozendict, see https://discuss.python.org/t/provide-a-c-api-to-efficently-convert-dict-into-frozendict/107754/8 for new API discussion, it is a WIPIf anyone wants to help - I would be really happy :)