gh-127681: Fix overflow vulnerabilities in PyMem_Malloc calls#153489
Open
pranavchoudhary-tech wants to merge 3 commits into
Open
gh-127681: Fix overflow vulnerabilities in PyMem_Malloc calls#153489pranavchoudhary-tech wants to merge 3 commits into
pranavchoudhary-tech wants to merge 3 commits into
Conversation
pranavchoudhary-tech
requested review from
StanFromIreland,
ericsnowcurrently,
gpshead,
iritkatriel,
markshannon,
methane and
pganssle
as code owners
pranavchoudhary-tech
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #127681 by systematically replacing PyMem_Malloc calls involving arithmetic with PyMem_New or adding explicit PY_SSIZE_T_MAX checks, as well as adding safety notes to appropriately constrained variables.