gh-148589: Clarify PyThreadState_GetFrame thread state requirement#153516
gh-148589: Clarify PyThreadState_GetFrame thread state requirement#153516zainnadeem786 wants to merge 1 commit into
Conversation
Documentation build overview
|
|
I've asked you before to please use your own critical thinking when using an AI agent to triage issues and/or make PRs. This change deviates from the wording of every other |
|
Hi @ZeroIntensity, I'd like to clarify one point. I don't think it's fair to assume that I rely on AI instead of my own reasoning. I do use AI as a research and drafting aid at times, but I review, verify, and take responsibility for everything I submit. If there was a specific technical issue with this PR, I'd appreciate feedback on that rather than assumptions about how it was written. That would help me improve future contributions. Thanks. |
I told you what the technical problems with this PR were. If you read my comment on the issue, you would understand why I don't believe this is the right change. I'm not saying you're not reviewing your work at all, but I am saying that you're not reviewing it enough. I urge you to review our AI policy before continuing to submit PRs. For future contributions, please just do the work on your own merits, or otherwise significantly review your agent's output before sending it to us. AI is fine to use as an assistant or a reference, but it shouldn't handle every step of the process. Just because an agent can provide working code or a documentation change does not mean it has all the right context. Sorry if this comes off as harsh, but this is a recurring pattern I've seen in your contributions. CPython is a volunteer-run project; we have nothing to gain by stopping you from using AI in your contributions, but we also have limited time. If you can effectively submit AI-generated contributions that are productive, we are happy to consider them, but otherwise, it is a waste of reviewer time and unfair to those who do put thoughtful research into their contributions. |
Summary
Clarify that
PyThreadState_GetFrame()expects the supplied thread state to be the thread state attached to the current OS thread.This follows the maintainer discussion in GH-148589 and matches the glossary definition of an attached thread state.
This is a documentation-only change. No runtime behavior is changed.
Close: gh-148589