Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions Lib/_colorize.py
Original file line number Diff line number Diff line change
Expand Up @@ -603,6 +603,8 @@ def _safe_getenv(k: str, fallback: str | None = None) -> str | None:
return os.isatty(file.fileno())
except OSError:
return hasattr(file, "isatty") and file.isatty()
except ValueError:
return False


default_theme = Theme()
Expand Down
5 changes: 5 additions & 0 deletions Lib/test/test__colorize.py
Original file line number Diff line number Diff line change
Expand Up @@ -187,6 +187,11 @@ def test_colorized_detection_checks_for_file(self):
file.isatty.return_value = False
self.assertEqual(_colorize.can_colorize(file=file), False)

# gh-157581: A closed file raises ValueError from fileno().
file = unittest.mock.Mock()
file.fileno.side_effect = ValueError
self.assertFalse(_colorize.can_colorize(file=file))


if __name__ == "__main__":
unittest.main()
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Updated :func:``!_colorize.can_colorize`` to not raise when given a closed file stream.
Loading