gh-157833: Fix specialized C calls with additional method flags - #157834
Merged
Merged
Conversation
overcat
requested review from
Fidget-Spinner,
markshannon,
savannahostrowski and
tomasr8
as code owners
September 20, 2026 01:19
|
All commit authors signed the Contributor License Agreement. |
cocolato
reviewed
Sep 20, 2026
cocolato
left a comment
cocolato
left a comment
Member
There was a problem hiding this comment.
we can add a mask macro like this:
#define _Py_METH_CALL_FLAGS \
(METH_VARARGS | METH_FASTCALL | METH_NOARGS | METH_O | METH_KEYWORDS | METH_METHOD)
cocolato
reviewed
Sep 21, 2026
markshannon
approved these changes
Sep 30, 2026
cocolato
added
the
needs backport to 3.15
|
Thanks @overcat for the PR, and @markshannon for merging it 🌮🎉.. I'm working now to backport this PR to: 3.15. |
|
GH-158544 is a backport of this pull request to the 3.15 branch. |
bedevere-app
Bot
removed
the
needs backport to 3.15
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #157833
Ignore
METH_CLASS,METH_STATICandMETH_COEXISTin the specialized C call guards and corresponding Tier 2 optimizer checks. This prevents calls accepted by the specializer from failing their flag guards on every call.METH_METHODremains checked because it changes the C calling convention.Add Tier 1 and Tier 2 regression tests for all seven affected instructions, regenerate the affected files.
METH_CLASS,METH_STATICorMETH_COEXIST#157833