Skip to content

gh-157906: fix an incorrect architecture macro check in free-threaded GC - #157907

Merged
nascheme merged 2 commits into
python:mainfrom
lpyu001:gc_free_threading
Oct 3, 2026
Merged

nascheme merged 2 commits into
python:mainfrom
lpyu001:gc_free_threading

Conversation

@lpyu001

@lpyu001 lpyu001 commented Sep 21, 2026 •

Copy link
Copy Markdown
Contributor

@lpyu001

lpyu001 commented Sep 21, 2026

Copy link
Copy Markdown
Contributor Author

cc @nascheme

@lpyu001 lpyu001 changed the title gh-157906: fix typo in free-threaded GC prefetch check for 32-bit MSVC gh-157906: fix Fix an incorrect architecture macro check in free-threaded GC prefetch check for 32-bit MSVC Sep 22, 2026
@lpyu001 lpyu001 changed the title gh-157906: fix Fix an incorrect architecture macro check in free-threaded GC prefetch check for 32-bit MSVC gh-157906: fix an incorrect architecture macro check in free-threaded GC Sep 22, 2026
@lpyu001 lpyu001 closed this Sep 23, 2026
@lpyu001
lpyu001 deleted the gc_free_threading branch September 23, 2026 02:54
@lpyu001
lpyu001 restored the gc_free_threading branch September 23, 2026 02:57
@lpyu001 lpyu001 reopened this Sep 23, 2026
@nascheme
nascheme merged commit 1b015e6 into python:main Oct 3, 2026
109 checks passed
@nascheme nascheme added topic-free-threading type-bug An unexpected behavior, bug, or error performance Performance or resource usage labels Oct 3, 2026
@nascheme

nascheme commented Oct 3, 2026

Copy link
Copy Markdown
Member

Thanks for the fix! You might want to submit the same fix to zstd since it's where this "ifdef" logic came from and it has the same typo.

@bedevere-bot

Copy link
Copy Markdown

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot AMD64 Windows PGO NoGIL Tailcall 3.x (tier-1) has failed when building commit 1b015e6.

What do you need to do:

  1. Don't panic.
  2. Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
  3. Go to the page of the buildbot that failed (https://buildbot.python.org/#/builders/1871/builds/1681) and take a look at the build logs.
  4. Check if the failure is related to this commit (1b015e6) or if it is a false positive.
  5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/#/builders/1871/builds/1681

Failed tests:

  • test_logging
  • test_external_inspection
  • test_profiling

Failed subtests:

  • test_tlbc_cache_refresh_after_slot_fill - test.test_external_inspection.TestGetStackTrace.test_tlbc_cache_refresh_after_slot_fill
  • test_rollover_based_on_st_birthtime_only - test.test_logging.TimedRotatingFileHandlerTest.test_rollover_based_on_st_birthtime_only
  • test_run_blocking_exits_after_target_process_exits - test.test_profiling.test_sampling_profiler.test_blocking.TestBlockingModeCLI.test_run_blocking_exits_after_target_process_exits

Summary of the results of the build (if available):

==

Click to see traceback logs
Traceback (most recent call last):
  File "C:\bbarea\3.x.itamaro-win64-srv-22-aws.nogil.tailcall.pgo\build\Lib\test\test_external_inspection.py", line 2446, in test_tlbc_cache_refresh_after_slot_fill
    self.assertEqual(
    ~~~~~~~~~~~~~~~~^
        result.returncode, 0,
        ^^^^^^^^^^^^^^^^^^^^^
        f"stdout: {result.stdout}\nstderr: {result.stderr}",
        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    )
    ^
AssertionError: 1 != 0 : stdout: 
stderr: OSError: [WinError 299] Only part of a ReadProcessMemory or WriteProcessMemory request was completed


Traceback (most recent call last):
  File "C:\bbarea\3.x.itamaro-win64-srv-22-aws.nogil.tailcall.pgo\build\Lib\test\test_logging.py", line 6831, in test_rollover_based_on_st_birthtime_only
    self.assertTrue(found, msg=msg)
    ~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^
AssertionError: False is not true : No rotated files found, went back 5 seconds


Traceback (most recent call last):
  File "<string>", line 40, in <module>
    cached = lines(u, 2)
  File "<string>", line 18, in lines
    traces = u.get_stack_trace()
OSError: ReadProcessMemory failed for PID 3212 at address 0x1 (size 80, partial read 0 bytes): Windows error 299


Traceback (most recent call last):
  File "C:\bbarea\3.x.itamaro-win64-srv-22-aws.nogil.tailcall.pgo\build\Lib\test\test_profiling\test_sampling_profiler\test_blocking.py", line 198, in test_run_blocking_exits_after_target_process_exits
    self.assertEqual(
    ~~~~~~~~~~~~~~~~^
        result.returncode, 0,
        ^^^^^^^^^^^^^^^^^^^^^
        f"stdout:\n{result.stdout}\nstderr:\n{result.stderr}",
        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    )
    ^
AssertionError: 1 != 0 : stdout:
done


Traceback (most recent call last):
  File "C:\bbarea\3.x.itamaro-win64-srv-22-aws.nogil.tailcall.pgo\build\Lib\test\test_external_inspection.py", line 2446, in test_tlbc_cache_refresh_after_slot_fill
    self.assertEqual(
    ~~~~~~~~~~~~~~~~^
        result.returncode, 0,
        ^^^^^^^^^^^^^^^^^^^^^
        f"stdout: {result.stdout}\nstderr: {result.stderr}",
        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    )
    ^
AssertionError: 1 != 0 : stdout: 
stderr: Traceback (most recent call last):
  File "<string>", line 40, in <module>
    cached = lines(u, 2)
  File "<string>", line 18, in lines
    traces = u.get_stack_trace()
RuntimeError: Cannot read non-compact Unicode object at 0x8201fbc0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

performance Performance or resource usage topic-free-threading type-bug An unexpected behavior, bug, or error

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants