Conversation
…r.map()` _process_chunk() returned a failed call's bare exception, so ProcessPoolExecutor.map() lost the _RemoteTraceback cause that _process_worker() attaches. Wrap it in _ExceptionWithTraceback. _MapResultIterator.__next__() kept the exception it raised in a local, so the exception referenced its own raising frame through its traceback. Clear the local after raising, as Future.__get_result() does.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ProcessPoolExecutor.map()returned a failed call's exception without the worker traceback, and_MapResultIterator.__next__()kept the exception it re-raised in a local, which put it in a reference cycle with its own traceback. The chunk worker now wraps the exception in_ExceptionWithTraceback, as_process_worker()does, and__next__()clears the local after raising.No NEWS entry, since the affected code is new in 3.16 and has not been released.
Executor.map()exceptions lose the worker traceback and form a cycle #158497