Skip to content

gh-158536: Skip some Android logging tests on OS versions with aggressive "chatty" filtering - #158531

Merged
freakboy3742 merged 1 commit into
python:mainfrom
mhsmith:android-logcat-chatty
Sep 30, 2026
Merged

gh-158536: Skip some Android logging tests on OS versions with aggressive "chatty" filtering#158531
freakboy3742 merged 1 commit into
python:mainfrom
mhsmith:android-logcat-chatty

Conversation

@mhsmith

@mhsmith mhsmith commented Sep 30, 2026 •
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Member

For details see:

The tests produce 3 consecutive blank lines, but the affected versions of Android only log one blank line, followed by a marker that says "chatty ... Identical 3 lines". The only option I can see is to skip that part of the test.

This wasn't discovered before because it doesn't affect either our minimum or maximum versions of Android, only some in the middle.

@mhsmith mhsmith added skip issue skip news needs backport to 3.14 bugs and security fixes needs backport to 3.15 pre-release feature fixes, bugs and security fixes labels Sep 30, 2026
@bedevere-app bedevere-app Bot added awaiting review tests Tests in the Lib/test dir labels Sep 30, 2026
freakboy3742
freakboy3742 approved these changes Sep 30, 2026
View reviewed changes

@freakboy3742 freakboy3742 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Annoying, but I'm not sure I see an alternative here either.

@freakboy3742 freakboy3742 changed the title Skip some Android logging tests on OS versions with aggressive "chatty" filtering gh-158536: Skip some Android logging tests on OS versions with aggressive "chatty" filtering Sep 30, 2026
@freakboy3742 freakboy3742 self-assigned this Sep 30, 2026
@bedevere-app bedevere-app Bot mentioned this pull request Sep 30, 2026
Closed
@freakboy3742
freakboy3742 merged commit 763b6ed into python:main Sep 30, 2026
107 of 109 checks passed
@miss-islington-app

miss-islington-app Bot commented Sep 30, 2026

Copy link
Copy Markdown

Thanks @mhsmith for the PR, and @freakboy3742 for merging it 🌮🎉.. I'm working now to backport this PR to: 3.14, 3.15.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

@bedevere-app

bedevere-app Bot commented Sep 30, 2026

Copy link
Copy Markdown

GH-158537 is a backport of this pull request to the 3.15 branch.

@bedevere-app bedevere-app Bot removed the needs backport to 3.15 pre-release feature fixes, bugs and security fixes label Sep 30, 2026
@bedevere-app

bedevere-app Bot commented Sep 30, 2026

Copy link
Copy Markdown

GH-158538 is a backport of this pull request to the 3.14 branch.

@bedevere-app bedevere-app Bot removed the needs backport to 3.14 bugs and security fixes label Sep 30, 2026
freakboy3742 pushed a commit that referenced this pull request Sep 30, 2026
@miss-islington @mhsmith
[3.14] gh-158536: Skip some Android logging tests on OS versions with…
e47e101 
… aggressive "chatty" filtering (GH-158531) (#158538)

Address a test suite failure when run on Android 26-30 (inclusive) due to the
adb logger dropping lines with a "chatty ... Identical 3 lines" marker.
(cherry picked from commit 763b6ed)

Co-authored-by: Malcolm Smith <smith@chaquo.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@freakboy3742 freakboy3742 freakboy3742 approved these changes

Assignees

@freakboy3742 freakboy3742

Labels

OS-android skip news tests Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@mhsmith @freakboy3742