[3.14] gh-156321: Don't eagerly log exceptions from a cancelled asyncio.shield() (GH-158590) - #158599
Merged
Merged
Conversation
…o.shield() (pythonGH-158590) When the outer future returned by shield() was cancelled, a callback was added to the inner future that reported its exception through the loop exception handler as soon as it completed, even if the exception was retrieved afterwards by awaiting the inner future or calling `exception()`. Remove the callback; an exception nobody retrieves is still reported by the inner future itself when it is garbage collected, like any other future. (cherry picked from commit 2095eab) Co-authored-by: Kumar Aditya <kumaraditya@python.org>
miss-islington
requested review from
1st1,
asvetlov,
kumaraditya303 and
willingc
as code owners
October 2, 2026 12:57
kumaraditya303
approved these changes
Oct 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the outer future returned by shield() was cancelled, a callback was
added to the inner future that reported its exception through the loop
exception handler as soon as it completed, even if the exception was
retrieved afterwards by awaiting the inner future or calling
exception(). Remove the callback; an exception nobody retrieves isstill reported by the inner future itself when it is garbage collected,
like any other future.
(cherry picked from commit 2095eab)
Co-authored-by: Kumar Aditya kumaraditya@python.org