Skip to content

gh-158839: Normalize falsy exc_info values in LogRecord #158840

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
srittau wants to merge 2 commits into
base: main
Choose a base branch
from
+7 −0
Open

gh-158839: Normalize falsy exc_info values in LogRecord #158840

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
70b7149
[logging] Normalize falsy exc_info values
srittau Oct 5, 2026
96073f8
Fix unknown reference target
srittau Oct 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions Lib/logging/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1680,6 +1680,8 @@ def _log(self, level, msg, args, exc_info=None, extra=None, stack_info=False,
exc_info = (type(exc_info), exc_info, exc_info.__traceback__)
elif not isinstance(exc_info, tuple):
exc_info = sys.exc_info()
else:
exc_info = None
record = self.makeRecord(self.name, level, fn, lno, msg, args,
exc_info, func, extra, sinfo)
self.handle(record)
Expand Down
5 changes: 5 additions & 0 deletions Misc/NEWS.d/next/Library/2026-10-05-14-58-12.gh-issue-158839.wYd6fI.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
The log functions in the :mod:`logging` module and the
:class:`logging.Logger` class now normalize falsy ``exc_info`` arguments to
``None`` before passing them to :meth:`logging.Logger.makeRecord` and
subsequently to :class:`logging.LogRecord`. This aligns
``logging.LogRecord.exc_info`` with the documentation.
Loading