Conversation
…es subclass _Unpickler_ReadFromFile() resized the object returned by read() in place, which is invalid for a bytes subclass. Copy it into an exact bytes object first.
|
Could we verify that every possible path to |
Author
|
Four |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pickle.load()crashes when a file object'sread()returns abytessubclass and the data is large enough to need several reads._Unpickler_ReadFromFile()grows the result with_PyBytes_Resize(), which is only valid for exactbytes. The fix copies a subclass instance into an exactbytesobject first. A regression test and a NEWS entry are included.The new test segfaults on a debug build without the fix and passes with it. test_pickle, test_pickletools, test_copyreg and test_picklebuffer pass.
AI disclosure: written with Claude Code assistance; I reviewed the change and ran the tests.
Fixes #158841.
AI-assisted: I used Claude Code to help write this change. I reviewed it and ran test_pickle, test_pickletools, test_copyreg and test_picklebuffer on a debug build.