Repository navigation
Conversation
…hase The "Process Python libraries" build phase sources utils.sh through an unquoted $PROJECT_DIR. The build fails when the project path contains a space, and a *, ? or [ in the path is glob-expanded, so the phase can source another directory's utils.sh. Quote the path in the four testbed projects.
The build phase example in Doc/using/ios.rst, and the one in the utils.sh header comment, source an unquoted path to build_utils.sh. The helper is named utils.sh. Quote the path and use the right file name.
Documentation build overview
|
Member
|
@fametrano Thanks for the PR, please sign the CLA: #162035 (comment) |
Author
done |
Member
|
Thanks! And please could you sign the CLA again? :) See https://devguide.python.org/getting-started/pull-request-lifecycle/#why-do-i-need-to-sign-the-cla-again which is about backports, but will be triggered here by merging in main. Tip: no need to merge in main unless there's a merge conflict to resolve, or there's been a long time since the last run. |
Author
|
Got it, won't update the branch anymore and/or will sign again |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Apple testbed fails to build when its path contains a space, because the "Process Python libraries" build phase sources
utils.shthrough an unquoted$PROJECT_DIR. A*,?or[in the path is glob-expanded as well, so the phase can source another directory'sutils.sh. This quotes that path in the iOS, tvOS, visionOS and watchOS testbed projects, and in the example inDoc/using/ios.rstand theutils.shheader, where it also replaces the nonexistentbuild_utils.shwithutils.sh.With the change, an iOS testbed cloned under a path with a space builds and passes
run -- platformon the iOS 27.2 simulator, and the build phase run withPROJECT_DIR=<dir>/run[x]sources its ownutils.sh. The other three projects take the same one-line change; I had no simulator for them.