Skip to content

Sect. 3 (Lifecycle of a Pull Request) does not mention Misc/NEWS.d/next and blurb #674

Description

@jwuttke

The explanations how to create a pull request are incomplete. They should mention

  • That in general a news file is requested.
  • How this file can be generated using blurb.
  • Under which conditions the "skip news" label can be set.

Activity

  1. methane commented on Apr 14, 2021

    @methane
    Member

    blurb and news entry are described in https://devguide.python.org/committing/#updating-news-and-what-s-new-in-python

    Maybe, it's old workflow. Contributor writes patch without news. Core developer commit the patch with news.

    In current workflow, we ask contributors to write news entry. So let's move the section from "16. Accepting Pull Requests" to "3. Lifecycle of a Pull Request".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    type-featureAdditions; New content or section needed

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions