Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions mypy/plugins/dataclasses.py
Original file line number Diff line number Diff line change
Expand Up @@ -599,6 +599,10 @@ def collect_attributes(self) -> list[DataclassAttribute] | None:
# This might be a property / field name clash.
# We will issue an error later.
continue
if isinstance(node, TypeInfo):
# The declared type is shadowed by a class created from a call like
# `x: Foo = namedtuple('Foo', [...])`, so there is no dataclass field here.
continue

assert isinstance(node, Var), node

Expand Down
13 changes: 13 additions & 0 deletions test-data/unit/check-dataclasses.test
Original file line number Diff line number Diff line change
Expand Up @@ -2746,6 +2746,19 @@ class B2(B1): # E: A NamedTuple cannot be a dataclass

[builtins fixtures/tuple.pyi]

[case testNoCrashForDataclassFieldAssignedFunctionalNamedTuple]
from collections import namedtuple
from dataclasses import dataclass

@dataclass
class C:
p: "Point" = namedtuple("Point", ["x", "y"]) # E: First argument to namedtuple() should be "p", not "Point"

@dataclass
class D:
Point: "Point" = namedtuple("Point", ["x", "y"])
[builtins fixtures/tuple.pyi]

[case testDataclassesTypeGuard]
import dataclasses

Expand Down
Loading