Repository navigation
[WIP] Fix failing GitHub Actions job for mypyc tests #22489
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
+2
−2
Closed
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -174,7 +174,7 @@ jobs: | |||||
| sudo apt-get update -q | ||||||
| sudo apt-get install -q -y --no-install-recommends \ | ||||||
| build-essential gdb lcov libbz2-dev libffi-dev libgdbm-dev liblzma-dev libncurses5-dev \ | ||||||
| libreadline6-dev libsqlite3-dev libssl-dev lzma lzma-dev tk-dev uuid-dev zlib1g-dev | ||||||
| libreadline6-dev libsqlite3-dev libssl-dev tk-dev uuid-dev zlib1g-dev | ||||||
| ./configure --prefix=/opt/pythondev | ||||||
| make -j$(nproc) | ||||||
| sudo make install | ||||||
|
|
@@ -191,7 +191,7 @@ jobs: | |||||
| sudo apt-get update -q | ||||||
| sudo apt-get install -q -y --no-install-recommends \ | ||||||
| build-essential gdb lcov libbz2-dev libffi-dev libgdbm-dev liblzma-dev libncurses5-dev \ | ||||||
| libreadline6-dev libsqlite3-dev libssl-dev lzma lzma-dev tk-dev uuid-dev zlib1g-dev | ||||||
| libreadline6-dev libsqlite3-dev libssl-dev tk-dev uuid-dev zlib1g-dev | ||||||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||
| ./configure CFLAGS="-DPy_DEBUG -DPy_TRACE_REFS -DPYMALLOC_DEBUG" --with-pydebug -with-trace-refs --prefix=/opt/pythondev | ||||||
| make -j$(nproc) | ||||||
| sudo make install | ||||||
|
|
||||||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lzma-devis only available up until ubuntu-24.04. The replacement for it isliblzma-dev. I'd also suggest to pin the OS version toubuntu-26.04for that job so it doesn't fail accidentally if for some reason a runner still uses the old 24.04 image.Btw: Even the cpython dev guide still references the "old" dependency if you like to upgrade that, too. https://devguide.python.org/getting-started/setup-building/#install-dependencies -> Linux -> Ubuntu