Repository navigation
Fix Literal.__args__ attribute error - #22493
Open
zhengdaodeguL wants to merge 1 commit into
Open
zhengdaodeguL wants to merge 1 commit into
zhengdaodeguL wants to merge 1 commit into
Conversation
Contributor
|
Diff from mypy_primer, showing the effect of this PR on open source code: spark (https://github.com/apache/spark)
+ python/pyspark/pandas/internal.py:768: error: Unused "type: ignore" comment [unused-ignore]
+ python/pyspark/pandas/internal.py:796: error: Unused "type: ignore" comment [unused-ignore]
pydantic (https://github.com/pydantic/pydantic)
+ pydantic/plugin/_schema_validator.py:18: error: Unused "type: ignore" comment [unused-ignore]
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #22491
Accessing
__args__on a parameterizedLiteral[...]alias reported"<typing special form>" has no attribute "__args__", even though theattribute exists at runtime (and pyright/ty do not report an error).
alias_type_in_runtime_contextreturned a plaintyping._SpecialForminstance for parameterized special-form aliases, and the
_SpecialFormstub has no
__args__member. This change attaches a per-instance__args__attribute typedtuple[Any, ...](via the existingInstance.extra_attrsmechanism) for parameterized aliases only. Barespecial forms (
Literal.__args__) and other missing attributes stillerror as before.
Added
testLiteralArgsAttributetocheck-literal.test, covering theissue repro (iterating
Key.__args__), the revealed type, and thenegative cases.
Verified with
pytest mypy/test/testcheck.pyon the check-literal,check-generics and check-type-aliases suites (405 passed, 3 skipped);
the new test fails on base code. Black and Ruff pass.