Skip to content

[PyMySQL] Replace Incomplete in MySQLResult, protocol and _auth - #16706

Merged
srittau merged 1 commit into
python:mainfrom
hnwg:pymysql-replace-incomplete
Nov 15, 2026
Merged

srittau merged 1 commit into
python:mainfrom
hnwg:pymysql-replace-incomplete

Conversation

@hnwg

@hnwg hnwg commented Nov 5, 2026

Copy link
Copy Markdown
Contributor

Fills in the remaining Incomplete annotations outside the deprecated ssl dict, based on PyMySQL 1.2.3:

  • read_length_encoded_integer returns an int, or None for a NULL column
  • sha1_new is functools.partial(hashlib.new, "sha1")
  • caching_sha2_password_auth returns the last packet, or None when it falls through after the RSA exchange
  • MySQLResult.description and rows match what _get_descriptions() and _read_rowdata_packet() build

Also drops MySQLResult.first_packet, which is a local variable in read() and not an attribute.

@github-actions

github-actions Bot commented Nov 5, 2026

Copy link
Copy Markdown
Contributor

According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉

@srittau
srittau merged commit 2ee8b31 into python:main Nov 15, 2026
74 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants