Skip to content

[PyMySQL] Fix the type of Cursor.description - #16707

Merged
srittau merged 1 commit into
python:mainfrom
hnwg:pymysql-cursor-description
Nov 15, 2026
Merged

srittau merged 1 commit into
python:mainfrom
hnwg:pymysql-cursor-description

Conversation

@hnwg

@hnwg hnwg commented Nov 5, 2026

Copy link
Copy Markdown
Contributor

Cursor.description is set from MySQLResult.description, which is a tuple of PEP 249 7-item tuples (name, type_code, None, internal_size, precision, scale, null_ok), not a tuple of strings. It's None until a query runs, so this uses | MaybeNone like sqlite3.Cursor.description.

@github-actions

github-actions Bot commented Nov 5, 2026

Copy link
Copy Markdown
Contributor

According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉

@srittau
srittau merged commit d93c237 into python:main Nov 15, 2026
74 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants