Skip to content

[pyserial] Allow None for Timeout duration - #16738

Open
aidxhxr wants to merge 1 commit into
python:mainfrom
aidxhxr:pyserial-timeout-none
Open

aidxhxr wants to merge 1 commit into
python:mainfrom
aidxhxr:pyserial-timeout-none

Conversation

@aidxhxr

@aidxhxr aidxhxr commented Nov 8, 2026

Copy link
Copy Markdown

serial.serialutil.Timeout takes None for a blocking port, and read() passes it whenever Serial.timeout is None (the default). time_left(), duration and target_time are then None too:

This adds None to those types.

Agent: Claude Code

@github-actions

github-actions Bot commented Nov 8, 2026

Copy link
Copy Markdown
Contributor

According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉

@aidxhxr

aidxhxr commented Nov 15, 2026

Copy link
Copy Markdown
Author

Friendly ping on this and #16739. Both add a missing None (the pyserial Timeout duration here, and KafkaConsumer.subscription() there), with links to the upstream source in the descriptions. CI is green and mypy_primer reports no changes.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant