Remove class-object assertion from defaults test - #2343
Merged
JelleZijlstra merged 1 commit intoAug 14, 2026
Merged
Conversation
AlexWaygood
approved these changes
Aug 14, 2026
AlexWaygood
left a comment
Member
There was a problem hiding this comment.
I believe the reason why I didn't change this one in #2204 was that we emit assert-type-unspellable-subtype for this one in ty instead of type-assertion-failure (since both the asserted type and the inferred type are fully static types), and we just switch off assert-type-unspellable-subtype when running ty on the conformance suite
Member
Author
I feel like we shouldn't be doing that, it weakens the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#2204 rewrote many defaults tests because type checkers are not required to infer a class expression as having a
type[C]type, but the assertion forsliceingenerics_defaults_referential.pywas missed. The same rationale applies here. I simply removed the line because the next line withslice()adequately tests the defaults.