Skip to content

Rename selective-build ROOT_OPS to SELECT_OPS_LIST - #21424

Open
sankalpsthakur wants to merge 3 commits into
pytorch:mainfrom
sankalpsthakur:refactor/12133-rename-root-ops
Open

Rename selective-build ROOT_OPS to SELECT_OPS_LIST#21424
sankalpsthakur wants to merge 3 commits into
pytorch:mainfrom
sankalpsthakur:refactor/12133-rename-root-ops

Conversation

@sankalpsthakur

@sankalpsthakur sankalpsthakur commented Jul 28, 2026

Copy link
Copy Markdown

Summary

  • Renames the gen_selected_ops CMake keyword ROOT_OPS to SELECT_OPS_LIST to match the existing EXECUTORCH_SELECT_OPS_LIST cache option.
  • Renames the matching gen_oplist CLI/API from --root_ops / root_ops to --select_ops_list / select_ops_list.
  • Updates call sites, docs, Buck shim, Zephyr samples, and unit test names accordingly.
  • Clean rename (no deprecation alias): the codebase does not already pattern cmake-option deprecation for this path.

Notes

  • Pre-existing: gen_oplist.py still prints the ops list to stdout (was print(root_ops)); left untouched to keep this PR rename-only.

Validation

  • Repo-wide search confirms no remaining ROOT_OPS / --root_ops / root_ops references outside third-party.
  • ast.parse syntax check on codegen/tools/gen_oplist.py and codegen/tools/test/test_gen_oplist.py.
  • Full pytest for test_gen_oplist.py not run locally (requires ExecuTorch/torch install).

Fixes #12133

AI/LLM disclosure

  • AI coding tools (including Grok and/or Codex agent-assisted editing) were used to help draft or modify code and this PR description.
  • I reviewed the complete change, understand the reasoning, and ran the reported local checks before submitting.
  • This submission is original work of authorship under the project CLA / contributor terms; AI output was not pasted unreviewed.

cc @mergennachin @nil-is-all @digantdesai @freddan80 @per @zingo @oscarandersson8218 @mansnils @Sebastian-Larsson @robell @rascani

@pytorch-bot

pytorch-bot Bot commented Jul 28, 2026

Copy link
Copy Markdown

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/21424

Note: Links to docs will display an error until the docs builds have been completed.

⚠️ 23 Awaiting Approval

As of commit c9e102c with merge base 5cdcc02 (image):

AWAITING APPROVAL - The following workflows need approval before CI can run:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla

meta-cla Bot commented Jul 28, 2026

Copy link
Copy Markdown

Hi @sankalpsthakur!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

@linux-foundation-easycla

linux-foundation-easycla Bot commented Jul 28, 2026

Copy link
Copy Markdown

CLA Signed
The committers listed above are authorized under a signed CLA.

@github-actions github-actions Bot added ciflow/trunk module: arm Issues related to arm backend labels Jul 28, 2026
@pytorch-bot

pytorch-bot Bot commented Jul 28, 2026

Copy link
Copy Markdown

The following ciflow label(s) have been added but CI has not been triggered yet because the workflows are awaiting approval:

  • ciflow/trunk

Once a maintainer approves the workflows (scroll to the bottom of the PR page), the corresponding CI jobs will be triggered automatically. Please ping one of the reviewers if you do not have access to approve and run workflows.

@nil-is-all nil-is-all removed ciflow/trunk module: arm Issues related to arm backend labels Jul 28, 2026
@meta-cla

meta-cla Bot commented Jul 28, 2026

Copy link
Copy Markdown

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jul 28, 2026
@nil-is-all nil-is-all added module: doc Issues related to documentation, both in docs/ and inlined in code enhancement Not as big of a feature, but technically not a bug. Should be easy to fix module: cleanup Issues/PRs which cleanup code across the repository labels Jul 28, 2026
@nil-is-all

Copy link
Copy Markdown
Contributor

Hi @sankalpsthakur, thanks for putting up the fix! While we review this PR, please do sign the CLA agreements in order to approve & merge contributions in this repository.

@sankalpsthakur

Copy link
Copy Markdown
Author

Thanks @nil-is-all — Meta CLA is signed (check green). EasyCLA is still showing unauthorized; I’m sorting that and pushed a lintrunner format fix for the SELECT_OPS_LIST call sites.

@github-actions github-actions Bot added ciflow/trunk module: arm Issues related to arm backend labels Jul 28, 2026
@nil-is-all

Copy link
Copy Markdown
Contributor

Thanks @nil-is-all — Meta CLA is signed (check green). EasyCLA is still showing unauthorized; I’m sorting that and pushed a lintrunner format fix for the SELECT_OPS_LIST call sites.

Thanks, running CI again. Do let us know if you need any help with signing EasyCLA.

Copy link
Copy Markdown
Author

@pytorchbot label "release notes: api"

@pytorch-bot pytorch-bot Bot added the release notes: api Changes to public facing apis (any interfaces, pybinded runtime methods, etc.) label Aug 15, 2026
@sankalpsthakur
sankalpsthakur force-pushed the refactor/12133-rename-root-ops branch 2 times, most recently from 1f60788 to f774b8c Compare August 17, 2026 06:11
@digantdesai

Copy link
Copy Markdown
Contributor

Ok with the rename, do we need buck file updated as well?

Copy link
Copy Markdown
Author

Yes — the Buck shim is already updated in this PR: shim_et/xplat/executorch/codegen/codegen.bzl now emits --select_ops_list= instead of --root_ops=.

@sankalpsthakur

sankalpsthakur commented Aug 19, 2026

Copy link
Copy Markdown
Author

Already covered in this PR: shim_et/xplat/executorch/codegen/codegen.bzl:221 now emits --select_ops_list= instead of --root_ops=. The Buck macro never took a ROOT_OPS parameter (et_operator_library(..., ops=...)), and a search of 258 *.bzl, 373 BUCK, and 2 TARGETS files found no remaining ROOT_OPS / --root_ops.

@sankalpsthakur

Copy link
Copy Markdown
Author

found 3 more ROOT_OPS references in .wiki/ examples that survived the rename, updated to SELECT_OPS_LIST. left the arduino README alone, its ROOT_OPS is a distinct shell var in build_arduino_library.sh, not the cmake arg.

Align gen_selected_ops / gen_oplist naming with EXECUTORCH_SELECT_OPS_LIST
so the cmake keyword is no longer a misnomer.

Fixes pytorch#12133
These three examples in .wiki/ still used the gen_selected_ops()
keyword argument this PR renamed.
@sankalpsthakur
sankalpsthakur force-pushed the refactor/12133-rename-root-ops branch from e9a62ad to c9e102c Compare September 5, 2026 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ciflow/trunk CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. enhancement Not as big of a feature, but technically not a bug. Should be easy to fix module: arm Issues related to arm backend module: cleanup Issues/PRs which cleanup code across the repository module: doc Issues related to documentation, both in docs/ and inlined in code release notes: api Changes to public facing apis (any interfaces, pybinded runtime methods, etc.)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Refactor cmake Selective Build Option ROOT_OPS

4 participants