Repository navigation
Add the ETDump product to the SwiftPM package template - #22286
Merged
Merged
Conversation
Companion to the change that adds ETDump profiling to the Apple frameworks. The published SwiftPM manifest is generated from this template, so the executorch_etdump product has to be declared here too, or the released package would be missing it. Adds the executorch_etdump product, which depends on the core executorch runtime.
…oduces The template declared executorch_etdump while the main-side half builds and publishes executorch_dump, so the two never agreed: the publish step would trip its "built framework has no product" check on every run. Renamed the product key, both checksum placeholders, and git-mv'd the two stub directories. Verified against the release job's own guards, with main's real framework list: with executorch_dump built both guards pass, and without it GUARD1 correctly blocks on the unsubstituted checksum rather than publishing.
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/22286
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 Unclassified FailureAs of commit b703bbb with merge base 1d467d0 ( UNCLASSIFIED FAILURE - DrCI could not classify the following job because the workflow did not run on the merge base. The failure may be pre-existing on trunk or introduced by this PR:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
meta-cla
Bot
added
the
CLA Signed
rascani
approved these changes
Aug 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Supersedes #22206. Same change, rebased onto the
swiftpmbranch now that the MLX halves have landed, plus the product-name fix.What #22206 got wrong
The template declared the product as
executorch_etdump, but themain-side half (#22205) builds and publishes a framework calledexecutorch_dump. The two never agreed, so the release job's own check would fire on every publishing run:Renamed the product key, both checksum placeholders, and git-mv'd the two stub directories to match.
Verified against the release job's guards
Replayed the publish step's two checks with main's real framework list:
The control firing is what makes the pass meaningful: the template is not silently permissive, it blocks when the framework is genuinely absent.
Coexists with MLX
Rebased onto
swiftpmat the merged MLX state. The materialized manifest carries 20 products including both pairs, with 0 unsubstituted placeholders anddump-packageclean:Landing
Land #22205 first. Until it is in, this half alone makes the publish step block on the unsubstituted
executorch_dumpchecksum, which stops the whole SwiftPM publish rather than just the dump product.