Skip to content

[ET-VK] Wire the missing resize functions for embedding and index_select #22410

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
msluszniak wants to merge 1 commit into
base: main
Choose a base branch
from
+4 −3
Open

[ET-VK] Wire the missing resize functions for embedding and index_select #22410

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions backends/vulkan/op_registry.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1412,6 +1412,7 @@ def register_index_select():
return OpFeatures(
inputs_storage=utils.CHANNELS_PACKED_TEXTURE,
inputs_dtypes=utils.FP_INT_BOOL_T,
supports_resize=True,
)


Expand Down
2 changes: 1 addition & 1 deletion backends/vulkan/runtime/graph/ops/impl/Embedding.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,7 +112,7 @@ void add_embedding_legacy_node(
// Resize Args
{},
// Resizing Logic
nullptr));
resize_embedding_node));
}

void embedding(ComputeGraph& graph, const std::vector<ValueRef>& args) {
Expand Down
4 changes: 2 additions & 2 deletions backends/vulkan/runtime/graph/ops/impl/IndexSelect.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ void add_index_select_channel_node(
// Resize Args
{},
// Resizing Logic
nullptr));
resize_index_select_channel_node));
}

struct IndexSelectParams final {
Expand Down Expand Up @@ -107,7 +107,7 @@ void add_index_select_node(
// Resize Args
{},
// Resizing Logic
nullptr));
resize_fn));
}

int64_t get_dim_idx(ComputeGraph& graph, ValueRef in, ValueRef dim_ref) {
Expand Down
Loading