Skip to content

Fix MLX C++20 errors #22424

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
metascroy merged 1 commit into from
Sep 2, 2026
Merged

Fix MLX C++20 errors #22424

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions backends/mlx/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -452,6 +452,14 @@ target_compile_options(mlxdelegate PRIVATE ${_common_compile_options})
# Core tensor headers carry pre-existing narrowing conversions that trip Xcode's
# -Wshorten-64-to-32 -Werror; suppress it here as XNNPACK and abseil already do.
target_compile_options(mlxdelegate PRIVATE -Wno-shorten-64-to-32)
# MLX headers use C++20 defaulted comparison operators while we build C++17.
# They normally arrive via -isystem from the imported mlx target, which
# suppresses the warning. But this backend also installs them for downstream
# consumers, and every -I is searched before any -isystem, so once an install
# has run they resolve out of ${CMAKE_INSTALL_PREFIX}/include instead and
# -Werror turns fatal. That is why an incremental rebuild used to need a
# cmake-out wipe: a clean tree has nothing installed yet.
target_compile_options(mlxdelegate PRIVATE -Wno-c++20-extensions)
if(EXECUTORCH_MLX_ENABLE_SANITIZERS)
target_link_options(mlxdelegate PRIVATE ${_mlx_sanitizer_link_options})
endif()
Expand Down
Loading