Skip to content

Qualcomm AI Engine Direct - Test int64 get_attr cast order in the rework suite - #24046

Open
msluszniak wants to merge 1 commit into
pytorch:mainfrom
msluszniak:ms/qnn-i64-cast-before-user
Open

Qualcomm AI Engine Direct - Test int64 get_attr cast order in the rework suite#24046
msluszniak wants to merge 1 commit into
pytorch:mainfrom
msluszniak:ms/qnn-i64-cast-before-user

Conversation

@msluszniak

@msluszniak msluszniak commented Oct 21, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Summary

The I64toI32 fix landed in #24222, so this now only adds the constant_cast_order subtest of test_i64_to_i32 to the rework suite.

Test plan

constant_cast_order failed on main before #24222.

cc @cccclai @winskuo-quic @shewu-quic @haowhsu-quic @DannyYuyang-quic @cbilgin @abhinaykukkadapu @psiddh @nil-is-all

@msluszniak
msluszniak requested a review from psiddh as a code owner October 21, 2026 06:56
@pytorch-bot

pytorch-bot Bot commented Oct 21, 2026 •
edited
Loading

Copy link
Copy Markdown

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/24046

Note: Links to docs will display an error until the docs builds have been completed.

⚠️ 15 Awaiting Approval

As of commit 09222a1 with merge base 4628b2b (image):

AWAITING APPROVAL - The following workflows need approval before CI can run:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Oct 21, 2026
@github-actions

github-actions Bot commented Oct 21, 2026

Copy link
Copy Markdown

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

@executorch-triage executorch-triage Bot added the community: contribution PRs coming from community (excluding hardware partners) label Oct 21, 2026
@nil-is-all nil-is-all added partner: qualcomm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Qualcomm module: qnn Issues related to Qualcomm's QNN delegate and code under backends/qualcomm/ labels Oct 21, 2026
@nil-is-all

nil-is-all commented Oct 29, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Tagging @qti-horodnic, @shewu-quic, @winskuo-quic, @chenweng-quic, @DannyYuyang-quic, @quic-boyuc, @qti-mmadhava, @zhaoxul-qti, @jethroqti to review. @msluszniak rebasing should resolve the unrelated CI failures. Do resolve merge conflicts as well, thanks

@msluszniak
Qualcomm AI Engine Direct - Test int64 get_attr cast order in the rew…
09222a1 
…ork suite

pytorch#24222 fixed I64toI32 casting a lifted int64 constant before its
definition. Add the matching subtest to test_i64_to_i32.
@msluszniak msluszniak changed the title Qualcomm AI Engine Direct - Cast an int64 get_attr right before its first user Qualcomm AI Engine Direct - Test int64 get_attr cast order in the rework suite Oct 30, 2026
@msluszniak
msluszniak force-pushed the ms/qnn-i64-cast-before-user branch from 0d118e0 to 09222a1 Compare October 30, 2026 11:50
@msluszniak

msluszniak commented Oct 30, 2026

Copy link
Copy Markdown
Contributor Author

Rebased. #24222 landed the same fix, so I dropped it here and kept only the rework-suite subtest. Happy to close this if the test in test_passes.py is enough.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@psiddh psiddh Awaiting requested review from psiddh psiddh is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

@psiddh psiddh

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. community: contribution PRs coming from community (excluding hardware partners) module: qnn Issues related to Qualcomm's QNN delegate and code under backends/qualcomm/ partner: qualcomm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Qualcomm

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@msluszniak @nil-is-all @psiddh