Repository navigation
[ET-VK][sdpa] Expose shader override - #24390
Merged
Merged
Conversation
Pull Request resolved: #24343 ## Ulterior Motive Benchmark SDPA shader routes without duplicating the production operator. ## Rationale Expose `sdpa_impl_with_shader_override()` to assemble the full SDPA operator while selecting its attention-value shader. The registered operator delegates to this function with no override, preserving automatic routing and the existing QK/softmax/AV dispatch chain. ```cpp sdpa_impl_with_shader_override( graph, args, graph.add_scalar(kShaderOverrideForceTile2)); ``` The override is a graph scalar using the existing SDPA route constants. Validation is provided by SDPA JSON cases and route sweeps in the later `benchmark_v2` commit. Authored with Codex (AI). ghstack-source-id: 461636572 @exported-using-ghexport Differential Revision: [D128509576](https://our.internmc.facebook.com/intern/diff/D128509576/)
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/24390
Note: Links to docs will display an error until the docs builds have been completed. ❌ 25 Pending, 6 Unclassified FailuresAs of commit 7cf132e with merge base aed328d ( UNCLASSIFIED FAILURES - DrCI could not classify the following jobs because the workflow did not run on the merge base. The failures may be pre-existing on trunk or introduced by this PR:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
meta-cla
Bot
added
the
CLA Signed
SS-JIA
approved these changes
Oct 31, 2026
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR was created by the merge bot to help merge the original PR into the main branch.
ghstack PR number: #24343 by @SS-JIA
^ Please use this as the source of truth for the PR details, comments, and reviews
ghstack PR base: https://github.com/pytorch/executorch/tree/gh/SS-JIA/677/base
ghstack PR head: https://github.com/pytorch/executorch/tree/gh/SS-JIA/677/head
Merge bot PR base: https://github.com/pytorch/executorch/tree/gh/SS-JIA/676/orig
Merge bot PR head: https://github.com/pytorch/executorch/tree/gh/SS-JIA/677/orig
Differential Revision: D128509576
@diff-train-skip-merge