Conversation
Fixes pytorch#3780 Signed-off-by: anish k <ak8686@princeton.edu>
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/tutorials/3839
Note: Links to docs will display an error until the docs builds have been completed. ❌ 2 New FailuresAs of commit 9a15df8 with merge base d445c1f ( NEW FAILURES - The following jobs have failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
|
@claude review this PR and offer any suggestions |
|
Claude finished @sekyondaMeta's task in 58s —— View job PR Review: Rename legacy Jenkins CI label to
|
|
Renamed the label to |
malfet
left a comment
There was a problem hiding this comment.
PR description is very confusing, not sure why linux.16xlarge.nvidia.gpu is called Rename legacy Jenkins CI label from, because this label never existed on Jenkins, but still exists on GitHub
|
@malfet Thanks for the review and approval. You are right that the original description was confusing — the label never existed on Jenkins itself, it existed in the GitHub CI metadata files. I have updated the PR title and description to accurately reflect the change: renaming the CI metadata label from |
|
Friendly ping — this has been approved by @malfet and CI is green. Is there anything else needed to get this merged? Happy to make any final adjustments. |
Fixes #3780
Summary
Renames the CI runner label
linux.16xlarge.nvidia.gputomulti-gpuin.jenkins/metadata.jsonand the corresponding filter in.jenkins/get_files_to_run.py.The old label was inherited from an earlier CI configuration and does not describe the actual hardware — it is used solely to route tutorials that require multiple GPUs to the correct CI shard. The new name
multi-gpumatches the existingneeds_multigpuvariable name inget_files_to_run.pyand accurately describes the semantic purpose of the label.Changes
.jenkins/metadata.json: Updated all 4 occurrences oflinux.16xlarge.nvidia.gputomulti-gpu.jenkins/get_files_to_run.py: Updated the equality check on line 44 to match the new labelNo routing logic or shard assignment behavior is changed — this is a label rename only.