Add animated detector slice diagrams - #1103
Open
ShallIBE wants to merge 2 commits into
Open
Conversation
Add a self-contained animation for detector slices with operations. Preserve exact Stim SVG frames at integer ticks and interpolate detector regions between ticks.
ShallIBE
marked this pull request as ready for review
August 20, 2026 09:46
Strilanc
requested changes
Aug 20, 2026
| } | ||
| }; | ||
|
|
||
| DetectorSliceSvgPath parse_shape(std::string_view tag) { |
Collaborator
There was a problem hiding this comment.
Why is this code doing any parsing? It should be generating images, not parsing images.
Is it consuming images produced elsewhere in the code and editing them? That is far too brittle.
Author
There was a problem hiding this comment.
Removed the SVG parsing. Detector geometry and style are now collected directly while the existing detector-slice renderer writes the SVG.
Strilanc
requested changes
Aug 20, 2026
| std::map<uint64_t, DetectorRegion> detector_regions; | ||
| }; | ||
|
|
||
| struct StringBuffer : std::streambuf { |
Collaborator
There was a problem hiding this comment.
Why not just std::stringstream?
| function fillOpacity(group){for(const e of group.querySelectorAll('path,circle'))if(e.getAttribute('stroke')==='none'&&e.getAttribute('fill')!=='none'){const value=Number(e.getAttribute('fill-opacity')||1);if(Number.isFinite(value))return value}return 1} | ||
| function decodePoints(text){const raw=atob(text),bytes=new Uint8Array(raw.length);for(let k=0;k<raw.length;k++)bytes[k]=raw.charCodeAt(k);return new Float32Array(bytes.buffer)} | ||
| function pathData(a,b,t){let d='M';for(let k=0;k<a.length/2;k++){if(k)d+='L';d+=(a[2*k]+(b[2*k]-a[2*k])*t).toFixed(4)+','+(a[2*k+1]+(b[2*k+1]-a[2*k+1])*t).toFixed(4)}return d+'Z'} | ||
| function replaceShape(element){if(!element)return null;const path=document.createElementNS(NS,'path');for(const attr of element.attributes){if(attr.name!=='d'&&attr.name!=='cx'&&attr.name!=='cy'&&attr.name!=='r')path.setAttribute(attr.name,attr.value)}element.replaceWith(path);return path} |
Collaborator
There was a problem hiding this comment.
Why does is this all mushed together?
Author
There was a problem hiding this comment.
Expanded the embedded JavaScript into readable functions
| StringBuffer buffer(capacity); | ||
| std::ostream out(&buffer); | ||
| write_animation_frames(std::move(frames), tick_slice_start, out); | ||
| return std::move(buffer.data); |
Author
There was a problem hiding this comment.
Added focused unit tests covering exact frame generation and detector transition behavior.
ShallIBE
marked this pull request as draft
August 24, 2026 22:43
Remove SVG parsing by collecting detector geometry during rendering. Use std::stringstream, format the embedded player, and add focused tests.
ShallIBE
force-pushed
the
animated-detslice-with-ops
branch
from
August 25, 2026 01:12
f44d7d0 to
1524b11
Compare
ShallIBE
marked this pull request as ready for review
August 25, 2026 01:43
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
animated-detslice-with-opstostim.Circuit.diagramandstim diagram.The result is a self-contained HTML animation of Stim’s existing
detslice-with-ops-svgoutput. Integer ticks use exact Stim SVG frames, while detector regions interpolate smoothly between ticks.Supports tick ranges and coordinate filtering. No external dependencies.