Repository navigation
fix(pampa): gate ModuleCompileError::find_in behind lua-filter - #862
Merged
Merged
Conversation
find_in refers to the cfg(feature = "lua-filter") mlua_error module, but the impl block was ungated, so pampa failed to compile with default-features = false. That is how wasm-qmd-parser depends on it, which broke the release pipeline's web-payloads job for v0.34.0 (run 38991132558). The only caller (quarto-core's lmd_execute) builds pampa with defaults. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The v0.34.0 Release run (38991132558) failed in
web-payloads→ Build wasm-qmd-parser:ModuleCompileError::find_in(added in 73588f3, bd-76ogq4ew) calls the#[cfg(feature = "lua-filter")]mlua_errormodule from an ungatedimpl, so pampa doesn't compile withdefault-features = false— which is howwasm-qmd-parserdepends on it. Regular CI doesn't exercise that build; only the release/nightly pipeline does, and last night's nightly predates the commit.Fix: gate the
implwith the same feature. The only caller (quarto-corelmd_execute.rs) uses pampa's default features.Verified:
cargo check -p pampa --no-default-featuresfails before / passes after;cargo check -p pampa -p quarto-coreclean.🤖 Generated with Claude Code