Fix bare CALL sites in configure.cmd that silently fail on Windows - #14851
Merged
Conversation
cmd.exe resolves a bare .bat/.cmd name (no path separator) through PATH search, not the current directory, so `call win_configuration.bat` and `call quarto-bld.cmd configure` both failed with "not recognized" and were never checked, leaving package/dist/bin/quarto.cmd unbuilt while configure.cmd still reported success. Prefixing both with .\ makes them explicit relative paths, which cmd.exe always resolves against the current directory.
Collaborator
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When running configure.cmd on Windows,
call win_configuration.batandCALL quarto-bld.cmd configureboth fail with "not recognized as an internal or external command", but neither failure is checked, so the script prints its usual success message and exits 0 without ever generatingpackage/dist/bin/quarto.cmd.Root Cause
cmd.exe resolves a bare .bat/.cmd name (no path separator) through PATH search rather than the current directory. Every other CALL in configure.cmd targets a path with a separator (a relative subdir, a %~dp0-prefixed path, or a full path variable), which cmd.exe always resolves against the current directory - these two were the only bare ones.
Fix
Prefix both call sites with .\ so they resolve as explicit relative paths instead of going through PATH search.
Test Plan
quarto --versionprinting correctly