Conversation
krlmlr
force-pushed
the
claude/readme-goals
branch
from
September 13, 2026 14:26
0f00825 to
0b44d78
Compare
krlmlr
force-pushed
the
claude/readme-goals
branch
from
September 13, 2026 14:29
0b44d78 to
e5bc052
Compare
krlmlr
force-pushed
the
claude/readme-goals
branch
3 times, most recently
from
September 13, 2026 16:31
44da833 to
855f9e9
Compare
krlmlr
force-pushed
the
claude/readme-goals
branch
from
September 13, 2026 16:59
855f9e9 to
cc42687
Compare
krlmlr
force-pushed
the
claude/readme-goals
branch
from
September 13, 2026 18:26
cc42687 to
0c10e62
Compare
krlmlr
force-pushed
the
claude/readme-goals
branch
from
September 13, 2026 18:38
0c10e62 to
447b399
Compare
krlmlr
added this pull request to stack #611
September 13, 2026 21:05
krlmlr
force-pushed
the
claude/readme-goals
branch
2 times, most recently
from
September 13, 2026 21:42
9ad9a43 to
fa79a6f
Compare
krlmlr
force-pushed
the
claude/readme-goals
branch
from
September 14, 2026 05:27
fa79a6f to
3c59035
Compare
Scope drawn from the README's own opening and its "Design notes" section
("This turns out to be too general: a driver has no real state, for PostgreSQL
each connection can only have one result set ... the driver class is just a
dummy class with no contents"), the DESCRIPTION (Imports DBI, bit64, blob, hms,
lubridate; SystemRequirements names libpq >= 9.0), the exported
PostgreSQL-specific helpers in NAMESPACE (postgresWaitForNotify(),
postgresImportLargeObject(), Redshift()), and tests/testthat/test-DBItest.R,
which runs DBItest::test_all().
The type-mapping goal claims a best fit rather than a lossless one.
src/PqResultImpl.cpp maps NUMERIC and MONEY to double, and INTERVAL and UUID to character,
so "without losing information" would not hold.
The Redshift non-goal names BLOBs only, which tests/testthat/helper-DBItest.R
still records as `omit_blob_tests = TRUE` in its Redshift context.
NEWS.md 1.4.0 also reported limitations enumerating temporary and persistent tables,
but 1.4.3 supersedes that entry: "Temporary tables are now discovered correctly
for `Redshift()` connections, all DBItest tests pass".
The "does not bundle a client library" non-goal says that no libpq source ships with the package,
rather than that the build relies on the system libpq.
The latter holds on Unix only: tools/winlibs.R downloads a prebuilt libpq on Windows,
and configure falls back to autobrew on macOS.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01WWhverMTZZKgEpUuTK117m
krlmlr
force-pushed
the
claude/readme-goals
branch
from
September 14, 2026 14:37
3c59035 to
12b1284
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Evidence:
Imports; the API takes SQL strings, with no query builder inNAMESPACE.SystemRequirements: libpq >= 9.0, and no libpq source in the package. The bullet deliberately does not say "the build relies on the systemlibpq": that holds on Unix, buttools/winlibs.Rdownloads a prebuilt libpq on Windows (statically linked bysrc/Makevars.win) andconfigurefalls back to autobrew on macOS when the local libpq is too old or lacks SSL. What survives across all three is that the package ships no libpq source.tests/testthat/helper-DBItest.Rstill carriesomit_blob_tests = TRUEin its Redshift context, andNEWS.md1.4.0 records it. The bullet stops there: 1.4.0 also reported "limitations with enumerating temporary and persistent tables", but 1.4.3 (2021-12-20) supersedes that entry — "Temporary tables are now discovered correctly forRedshift()connections, all DBItest tests pass (Allow to find table in temporary schema for Redshift #358)".src/PqResultImpl.cppmaps oid 1700 (NUMERIC/DECIMAL) and oid 790 (MONEY) toDT_REAL, i.e. double, and INTERVAL and UUID to character, so "without losing information" would not be true. What the code does support isbit64::integer64for BIGINT,blobforbytea, and a distinct datetime-with-timezone type.The Postgres-specific goals name the things DBI has no generic for:
postgresWaitForNotify(),postgresImportLargeObject(), andRedshift().The DBI specification is linked as
https://dbi.r-dbi.org/articles/spec.html— pkgdown on GitHub Pages does not append.htmlfor you.This package has no
README.Rmd, soREADME.mdis the source and was edited directly; nothing is rendered.Stacked on #606, which this PR targets.
🤖 Generated with Claude Code
https://claude.ai/code/session_01WWhverMTZZKgEpUuTK117m